fix: tighten MCPServer tool result typing#2881
Closed
sarvesh1327 wants to merge 4 commits into
Closed
Conversation
Kludex
reviewed
Jun 16, 2026
Comment on lines
+391
to
+393
| async def call_tool( | ||
| self, name: str, arguments: dict[str, Any], context: Context[LifespanResultT, Any] | None = None | ||
| ) -> Sequence[ContentBlock] | dict[str, Any]: | ||
| ) -> CallToolResult | Sequence[ContentBlock] | tuple[Sequence[ContentBlock], dict[str, Any]]: |
Member
There was a problem hiding this comment.
I think the reason I didn't do this is because I think we should only return CallToolResult from here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MCPServer._handle_call_toolMCPServer.call_toolto describe the actual converted result shapesFixes #2695.
Test Plan
uv run --frozen pytest tests/server/mcpserver/test_func_metadata.py -quv run --frozen ruff check src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_func_metadata.pyuv run --frozen pyright src/mcp/server/mcpserver/server.py tests/server/mcpserver/test_func_metadata.pyNotes